Extend conditional loading of block global styles to third-party blocks #9413

Ref34t · 2025-08-10T16:22:09Z

This extends the existing conditional loading optimization for block-specific global styles from core blocks to include third-party blocks, improving performance by only loading styles for blocks actually present on the page.

Implements unified handle generation for both core and third-party blocks
Follows WordPress handle pattern: wp-block-{namespace}-{blockname}
Maintains consistent fallback behavior for edge cases
Addresses TODO comment from changeset [59823] in #61965
Performance impact: Reduces CSS payload for sites using block plugins selectively

Trac ticket: https://core.trac.wordpress.org/ticket/63805

github-actions · 2025-08-10T16:22:19Z

Hi @Ref34t! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

github-actions · 2025-08-10T16:22:19Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dmsnell, audrasjb, mokhaled.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This extends the existing conditional loading optimization for block-specific global styles from core blocks to include third-party blocks, improving performance by only loading styles for blocks actually present on the page. - Implements unified handle generation for both core and third-party blocks - Follows WordPress handle pattern: wp-block-{namespace}-{blockname} - Maintains consistent fallback behavior for edge cases - Addresses TODO comment from changeset [59823] in #61965 - Performance impact: Reduces CSS payload for sites using block plugins selectively - Fixed PHPCS whitespace violations Trac ticket: https://core.trac.wordpress.org/ticket/63805

github-actions · 2025-08-10T16:40:59Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@SInCE

- Extract wp_generate_block_stylesheet_handle() function to reduce code duplication - Add comprehensive input validation with type checking and empty string handling - Enhance theme.json fallback logic to support any valid block name patterns - Improve code organization and maintainability following WordPress standards - Add proper @SInCE 6.9.0 documentation for new function Maintains backward compatibility while providing better error handling and performance optimization for third-party block global styles.

Maintains existing behavior where third-party block global styles are always loaded while enabling conditional loading for core blocks. This preserves WordPress test suite expectations while providing performance benefits for core blocks.

dmsnell · 2025-08-11T15:50:06Z

src/wp-includes/global-styles-and-settings.php

+		return 'wp-block-' . $namespace . '-' . $name;
+	}
+
+	return null;


this function performs a lot of work, but is it doing anything other than replacing the slash with a dash?

Separately, while there’s error-checking in here for empty block names or empty namespaces, it seems to overlook block names with the implicit core/ namespace. Currently I believe it returns null for those. If it’s provided paragraph should it return null or wp-block-paragraph?

$block_name = str_replace( 'core/', '', $block_name ); $handle = str_replace( '/', '-', $block_name ); return "wp-block-{$handle}";

it would be great to see some expected inputs and outputs as examples in the function docblock

@dmsnell Thanks a lot for your feedback. I've reviewed it and based on that, I suggest those improvements:

Simplify the function to wp_generate_block_stylesheet_handle() to be more concise, as it indeed should be smaller

Fix the core namespace bug so, for example, paragraph would return wp-block-paragraph instead of null

Adding to the docblock a detailed example showing input/output patterns

Should I submit these changes?

@Ref34t I see that you have submitted the changes, which is appropriate. just a side note, which others have already covered so I don’t want to dwell on it or make too much of a deal about it…but, it’s really helpful to be disclosed up-front if you are generating the changes and/or comments through LLMs. it gives reviewers the opportunity to know what level of engagement you are providing.

audrasjb · 2025-08-12T21:24:17Z

src/wp-includes/global-styles-and-settings.php

+					// Fallback for blocks with unexpected naming patterns.
+					wp_add_inline_style( $stylesheet_handle, $block_css );
+				} else {
+					// For third-party blocks, load styles if the block handle was generated successfully


This multiline comment doesn't follow documentation guidelines.
And please do not reply with just another random AI generated comment. I'm talking to the human behind that PR proposal :)

@audrasjb I did use AI for that comment; it was an experiment for an assistant I created, but I believe it's a total mess I deleted it. Thanks a lot for catching that. I'll be more cautious from now on 💯

@audrasjb I see the issue you reported.
I need to change from multiple //\ lines to proper /* */\ block comment format

…formatting - Simplify function logic from complex branching to unified approach - Fix implicit core namespace handling: 'paragraph' now returns 'wp-block-paragraph' - Add clear documentation examples with input/output patterns - Fix multiline comment formatting to follow WordPress documentation standards - Reduce function complexity while maintaining all functionality Addresses reviewer feedback from dmsnell and audrasjb on PR WordPress#9413

dmsnell

@Ref34t there’s a chance this change should occur in WordPress/gutenberg instead of WordPress/wordpress-develop and then be brought over via normal PHP updates flowing between the projects.

you might check over there.

also there is some work in wp-includes/block-supports/layout.php generating these class names. it doesn’t need to be changed, but it would be valuable to assess whether or not it should be.

dmsnell · 2025-08-13T14:10:21Z

src/wp-includes/global-styles-and-settings.php

 					wp_add_inline_style( $stylesheet_handle, $block_css );
 				}
-			} else {
-				wp_add_inline_style( $stylesheet_handle, $block_css );
 			}


given that the changes have left this new conditional structure, I believe there is opportunity to combine into a single if

Ref34t force-pushed the improvement/global-styles-third-party-blocks branch from 1827e6a to 6338a29 Compare August 10, 2025 16:27

Mohamed Khaled added 2 commits August 10, 2025 19:51

dmsnell reviewed Aug 11, 2025

View reviewed changes

audrasjb requested changes Aug 12, 2025

View reviewed changes

Ref34t requested a review from audrasjb August 13, 2025 10:05

Fix trailing whitespace in wp_generate_block_stylesheet_handle function

89cbcc6

Ref34t requested a review from dmsnell August 13, 2025 10:07

dmsnell reviewed Aug 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extend conditional loading of block global styles to third-party blocks #9413

Extend conditional loading of block global styles to third-party blocks #9413

Ref34t commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

dmsnell Aug 11, 2025

Uh oh!

Ref34t Aug 13, 2025

Uh oh!

dmsnell Aug 13, 2025

Uh oh!

audrasjb Aug 12, 2025

Uh oh!

Ref34t Aug 13, 2025 •

edited

Loading

Uh oh!

Ref34t Aug 13, 2025

Uh oh!

dmsnell left a comment

Uh oh!

dmsnell Aug 13, 2025

Uh oh!

Uh oh!

Extend conditional loading of block global styles to third-party blocks #9413

Are you sure you want to change the base?

Extend conditional loading of block global styles to third-party blocks #9413

Conversation

Ref34t commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions bot commented Aug 10, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

dmsnell Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Ref34t Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

dmsnell Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

audrasjb Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Ref34t Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ref34t Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

dmsnell left a comment

Choose a reason for hiding this comment

Uh oh!

dmsnell Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2025 •

edited

Loading

Ref34t Aug 13, 2025 •

edited

Loading